pgsql: Reset InstallXLogFileSegmentActive after walreceiver self-initia - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Reset InstallXLogFileSegmentActive after walreceiver self-initia
Date
Msg-id E1u1JrD-002vOZ-0d@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Reset InstallXLogFileSegmentActive after walreceiver self-initiated exit.

After commit cc2c7d65fc27e877c9f407587b0b92d46cd6dd16 added this flag,
failure to reset it caused assertion failures.  In non-assert builds, it
made the system fail to achieve the objectives listed in that commit;
chiefly, we might emit a spurious log message.  Back-patch to v15, where
that commit first appeared.

Bharath Rupireddy and Kyotaro Horiguchi.  Reviewed by Dilip Kumar,
Nathan Bossart and Michael Paquier.  Reported by Dilip Kumar.

This commit has been applied as of b4f584f9d2a1 in v15 and newer
versions.  This is required on stable branches of v13 and v14 to fix a
regression reported by Noah Misch, introduced by 1f95181b44c8, causing
spurious failures in archive recovery (neither streaming nor archive
recovery) with concurrent restartpoints.  The backpatched versions of
the patches have been aligned on these branches by me.  Tests have been
conducted by the both of us.

Discussion: https://postgr.es/m/CAFiTN-sE3ry=ycMPVtC+Djw4Fd7gbUGVv_qqw6qfzp=JLvqT3g@mail.gmail.com
Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com
Backpatch-through: 13

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3635a0a35aafd3bfa80b7a809bc6e91ccd36606a
Author: Noah Misch <noah@leadboat.com>

Modified Files
--------------
src/backend/access/transam/xlog.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Don't ERROR on PreallocXlogFiles() race condition.
Next
From: John Naylor
Date:
Subject: pgsql: Compute CRC32C using AVX-512 instructions where available