pgsql: Revert "Improve accounting for memory used by shared hash tables - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Revert "Improve accounting for memory used by shared hash tables
Date
Msg-id E1u0X8F-002YiJ-1v@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Revert "Improve accounting for memory used by shared hash tables"

This reverts commit f5930f9a98ea65d659d41600a138e608988ad122.

This broke the expansion of private hash tables, which reallocates the
directory. But that's impossible when it's allocated together with the
other fields, and dir_realloc() failed with BogusFree. Clearly, this
needs rethinking.

Discussion: https://postgr.es/m/CAApHDvriCiNkm=v521AP6PKPfyWkJ++jqZ9eqX4cXnhxLv8w-A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1aff1dc8dfa7584ddbc695e1aae0f767db66326f

Modified Files
--------------
src/backend/storage/ipc/shmem.c   |   4 +-
src/backend/utils/hash/dynahash.c | 281 +++++++++-----------------------------
src/include/utils/hsearch.h       |   3 +-
3 files changed, 66 insertions(+), 222 deletions(-)


pgsql-committers by date:

Previous
From: Amit Langote
Date:
Subject: pgsql: Make derived clause lookup in EquivalenceClass more efficient
Next
From: Tomas Vondra
Date:
Subject: Re: pgsql: Improve accounting for memory used by shared hash tables