pgsql: pgbench: Make set_random_seed() 64-bit everywhere. - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: pgbench: Make set_random_seed() 64-bit everywhere.
Date
Msg-id E1tyXDR-001bBG-27@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pgbench: Make set_random_seed() 64-bit everywhere.

Delete an intermediate variable, a redundant cast, a use of long and a
use of long long.  scanf() the seed directly into a uint64, now that we
can do that with SCNu64 from <inttypes.h>.

The previous coding was from pre-C99 times when %lld might not have been
there, so it read into an unsigned long.  Therefore behavior varied
by OS, and --random-seed would accept either 32 or 64 bit seeds.  Now
it's the same everywhere.

Author: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/b936d2fb-590d-49c3-a615-92c3a88c6c19%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/53a2a1564ae450a46a7c565756ab536b84150e36

Modified Files
--------------
src/bin/pgbench/pgbench.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: amcheck: Move common routines into a separate module
Next
From: Tomas Vondra
Date:
Subject: pgsql: amcheck: Add gin_index_check() to verify GIN index