pgsql: Stablize tests added in 3abe9dc188. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Stablize tests added in 3abe9dc188.
Date
Msg-id E1ty2Zm-001NPZ-2Z@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Stablize tests added in 3abe9dc188.
List pgsql-committers
Stablize tests added in 3abe9dc188.

The problem is that after the ALTER SUBSCRIPTION tap_sub SET PUBLICATION
command, we didn't wait for the new walsender to start on the publisher.
Immediately after ALTER, we performed Insert and expected it to replicate.
However, the replication could start from a point after the INSERT location,
and as the subscription isn't copying initial data, we could miss such an
Insert.

The fix is to wait for connection to be established between publisher and
subscriber before starting DML operations that are expected to replicate.

As per CI.

Reported-by: Andres Freund <andres@anarazel.de>
Author: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Discussion: https://postgr.es/m/CALDaNm2ms1deM5EYNLFEfESv_Kw=Y4AiTB0LP=qGS-UpFwGbPg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/474d7a1fd858d5ee138cf4504dcd93a9a3123a7d

Modified Files
--------------
src/test/subscription/t/007_ddl.pl | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: Fix guc_malloc calls for consistency and OOM checks
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Use thread-safe strftime_l() instead of strftime().