Revert workarounds for -Wmissing-braces false positives on old GCC
We have collected several instances of a workaround for GCC bug 53119,
which caused false-positive compiler warnings. This bug has long been
fixed, but was still seen on the buildfarm, most recently on lapwing
with gcc (Debian 4.7.2-5). (The GCC bug tracker mentions that a fix
was backported to 4.7.4 and 4.8.3.)
That compiler no longer runs warning-free since commit 6fdd5d95634, so
we don't need to keep these workarounds. And furthermore, the
consensus appears to be that we don't want to keep supporting that era
of platform anymore at all.
This reverts the following commits:
d937904cce6a3d82e4f9c2127de7b59105a134b3
506428d091760650971433f6bc083531c307b368
b449afb582bb9015bfbb85abc10ce122aef9ec70
6392f2a0968c20ecde4d27b6652703ad931fce92
bad0763a4d7be3005eae35d460c73ac4bc7ebaad
5e0c761d0a13c7b4f7c5de618ac38560d74d74d0
and makes a few similar fixes to newer code.
Discussion: https://www.postgresql.org/message-id/flat/e170d61f-01ab-4cf9-ab68-91cd1fac62c5%40eisentraut.org
Discussion:
https://www.postgresql.org/message-id/flat/CA%2BTgmoYEAm-KKZibAP3hSqbTFTjUd47XtVcf3xSFDpyecXX9uQ%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/618c64ffd3967cb5313b4b11e1e1043a074f2139
Modified Files
--------------
contrib/pg_prewarm/autoprewarm.c | 6 ++----
contrib/postgres_fdw/postgres_fdw.c | 3 +--
src/backend/optimizer/path/costsize.c | 3 +--
src/backend/storage/smgr/bulk_write.c | 2 +-
src/bin/pg_waldump/rmgrdesc.c | 4 ++--
src/bin/pgbench/pgbench.c | 7 +------
src/common/blkreftable.c | 12 ++++++------
src/common/file_utils.c | 2 +-
src/interfaces/libpq/fe-auth-oauth-curl.c | 2 +-
9 files changed, 16 insertions(+), 25 deletions(-)
