pgsql: Remove direct handling of reloptions for toast tables - Mailing list pgsql-committers

From Álvaro Herrera
Subject pgsql: Remove direct handling of reloptions for toast tables
Date
Msg-id E1tt0QB-002Phj-1s@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove direct handling of reloptions for toast tables

It doesn't actually work, even with allow_system_table_mods turned on:
the ALTER TABLE operation is rejected by ATSimplePermissions(), so even
the error message we're adding in this commit is unreachable.

Add a test case for it.

Author: Nikolay Shaplov <dhyan@nataraj.su>
Discussion: https://postgr.es/m/1913854.tdWV9SEqCh@thinkpad-pgpro

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1548c3a30436dd825cfbf57923c6766b2fddd355

Modified Files
--------------
src/backend/commands/tablecmds.c                              | 3 ++-
src/test/modules/unsafe_tests/expected/alter_system_table.out | 7 +++++++
src/test/modules/unsafe_tests/sql/alter_system_table.sql      | 4 ++++
3 files changed, 13 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Respect changing pin limits in read_stream.c.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Simplify and generalize PrepareSortSupportFromIndexRel()