pgsql: pg_logicalinspect: Stabilize isolation tests. - Mailing list pgsql-committers

From Masahiko Sawada
Subject pgsql: pg_logicalinspect: Stabilize isolation tests.
Date
Msg-id E1ts2Ug-001xJE-04@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_logicalinspect: Stabilize isolation tests.

The previous isolation tests did not account for the possibility that
the background writer or the checkpointer could write a RUNNING_XACTS
record, which could cause logical decoding to produce more logical
snapshots than expected.

This commit modifies the isolation tests to verify that at least one
logical snapshot contains the expected number of committed or ongoing
catalog-change transactions.

Per buildfarm member skink.

Reported-by: Andres Freund <andres@anarazel.de>
Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://postgr.es/m/5qbxud4pvnvmtuoi7weiizm5hmumxaeohx4vztfhrwlfhyz6rj@buh4435mllwo

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a49927f04cd0c66e1bc41f551160fce50f382d8c

Modified Files
--------------
.../pg_logicalinspect/expected/logical_inspect.out | 44 ++++++----------------
.../pg_logicalinspect/specs/logical_inspect.spec   | 24 +++++++++---
2 files changed, 30 insertions(+), 38 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Improve EXPLAIN's display of window functions.
Next
From: Masahiko Sawada
Date:
Subject: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p