pgsql: Fix ALTER TABLE error message - Mailing list pgsql-committers

From Álvaro Herrera
Subject pgsql: Fix ALTER TABLE error message
Date
Msg-id E1tpXdt-000n5E-19@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix ALTER TABLE error message

This bogus error message was introduced in 2013 by commit f177cbfe676d,
because of misunderstanding the processCASbits() API; at the time, no
test cases were added that would be affected by this change.  Only in
ca87c415e2fc was one added (along with a couple of typos), with an XXX
note that the error message was bogus.  Fix the whole, add some test
cases.

Backpatch all the way back.

Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Discussion: https://postgr.es/m/202503041822.aobpqke3igvb@alvherre.pgsql

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4e026be5f15994a7036eaca172126226e053f655

Modified Files
--------------
src/backend/parser/gram.y                 | 2 +-
src/test/regress/expected/foreign_key.out | 6 +++++-
src/test/regress/sql/foreign_key.sql      | 4 +++-
3 files changed, 9 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Masahiko Sawada
Date:
Subject: pgsql: Refactor Copy{From|To}GetRoutine() to use pass-by-reference argu
Next
From: Masahiko Sawada
Date:
Subject: pgsql: pg_upgrade: Check for the expected error message in TAP tests.