pgsql: Refactor COPY FROM to use format callback functions. - Mailing list pgsql-committers

From Masahiko Sawada
Subject pgsql: Refactor COPY FROM to use format callback functions.
Date
Msg-id E1to58i-000AeZ-03@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Refactor COPY FROM to use format callback functions.
List pgsql-committers
Refactor COPY FROM to use format callback functions.

This commit introduces a new CopyFromRoutine struct, which is a set of
callback routines to read tuples in a specific format. It also makes
COPY FROM with the existing formats (text, CSV, and binary) utilize
these format callbacks.

This change is a preliminary step towards making the COPY FROM command
extensible in terms of input formats.

Similar to 2e4127b6d2d, this refactoring contributes to a performance
improvement by reducing the number of "if" branches that need to be
checked on a per-row basis when sending field representations in text
or CSV mode. The performance benchmark results showed ~5% performance
gain in text or CSV mode.

Author: Sutou Kouhei <kou@clear-code.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Tomas Vondra <tomas.vondra@enterprisedb.com>
Reviewed-by: Junwang Zhao <zhjwpku@gmail.com>
Discussion: https://postgr.es/m/20231204.153548.2126325458835528809.kou@clear-code.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7717f63006935de00fafd000bff450280508adf1

Modified Files
--------------
src/backend/commands/copyfrom.c          | 192 ++++++++++---
src/backend/commands/copyfromparse.c     | 446 +++++++++++++++++--------------
src/include/commands/copy.h              |   2 -
src/include/commands/copyapi.h           |  50 +++-
src/include/commands/copyfrom_internal.h |  11 +
src/tools/pgindent/typedefs.list         |   1 +
6 files changed, 459 insertions(+), 243 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Avoid including explain.h in explain_format.h and explain_dr.h
Next
From: Sami Imseih
Date:
Subject: Re: pgsql: Trial fix for old cross-version upgrades.