pgsql: Allow EXPLAIN to indicate fractional rows. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Allow EXPLAIN to indicate fractional rows.
Date
Msg-id E1tlaRK-0001o3-1J@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Allow EXPLAIN to indicate fractional rows.

When nloops > 1, we now display two digits after the decimal point,
rather than none. This is important because what we print is actually
planstate->instrument->ntuples / nloops, and sometimes what you want
to know is planstate->instrument->ntuples. You can estimate that by
multiplying the displayed row count by the displayed nloops value, but
the fact that the displayed value is rounded makes that inexact. It's
still inexact even if we show these two extra decimal places, but less
so. Perhaps we will agree on a way to further improve this output later,
but for now this seems better than doing nothing.

Author: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Author: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Reviewed-by: David G. Johnston <david.g.johnston@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Vignesh C <vignesh21@gmail.com>
Reviewed-by: Greg Stark <stark@mit.edu>
Reviewed-by: Naeem Akhter <akhternaeem@gmail.com>
Reviewed-by: Hamid Akhtar <hamid.akhtar@percona.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Reviewed-by: Guillaume Lelarge <guillaume@lelarge.info>
Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com>
Reviewed-by: Alena Rybakina <a.rybakina@postgrespro.ru>
Discussion: http://postgr.es/m/603c8f070905281830g2e5419c4xad2946d149e21f9d%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ddb17e387aa28d61521227377b00f997756b8a27

Modified Files
--------------
src/backend/commands/explain.c                | 50 +++++++++++-----
src/test/regress/expected/explain.out         |  4 +-
src/test/regress/expected/memoize.out         | 86 +++++++++++++--------------
src/test/regress/expected/partition_prune.out | 42 ++++++-------
src/test/regress/expected/select_parallel.out | 24 ++++----
src/test/regress/sql/partition_prune.sql      |  2 +-
6 files changed, 113 insertions(+), 95 deletions(-)


pgsql-committers by date:

Previous
From: Masahiko Sawada
Date:
Subject: pgsql: Add test 005_char_signedness.pl to meson.build.
Next
From: Tom Lane
Date:
Subject: pgsql: Avoid race condition between "GRANT role" and "DROP ROLE".