pgsql: Raise a WARNING for max_slot_wal_keep_size in pg_createsubscribe - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Raise a WARNING for max_slot_wal_keep_size in pg_createsubscribe
Date
Msg-id E1tkHa4-007klT-2l@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Raise a WARNING for max_slot_wal_keep_size in pg_createsubscriber.

During the pg_createsubscriber execution, it is possible that the required
WAL is removed from the primary/publisher node due to
'max_slot_wal_keep_size'.

This patch raises a WARNING during the '--dry-run' mode if the
'max_slot_wal_keep_size' is set to a non-default value on the
primary/publisher node.

Author: Shubham Khanna <khannashubham1197@gmail.com>
Reviewed-by: Peter Smith <smithpb2250@gmail.com>
Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Reviewed-by: Vignesh C <vignesh21@gmail.com>
Discussion: https://postgr.es/m/CAHv8Rj+deqsQXOMa7Tck8CBQUbsua=+4AuMVQ2=MPM0f-ZHbjA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/217919dd0954f54402e8d0a38cd203a740754077

Modified Files
--------------
doc/src/sgml/ref/pg_createsubscriber.sgml   |  7 +++++++
src/bin/pg_basebackup/pg_createsubscriber.c | 20 +++++++++++++++++++-
2 files changed, 26 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: John Naylor
Date:
Subject: pgsql: Specialize intarray sorting
Next
From: David Rowley
Date:
Subject: pgsql: Fix poorly written regression test