pgsql: Add test of various escape functions - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Add test of various escape functions
Date
Msg-id E1thVPw-006Ny1-P6@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add test of various escape functions

As highlighted by the prior commit, writing correct escape functions is less
trivial than one might hope.

This test module tries to verify that different escaping functions behave
reasonably. It e.g. tests:

- Invalidly encoded input to an escape function leads to invalidly encoded
  output

- Trailing incomplete multi-byte characters are handled sensibly

- Escaped strings are parsed as single statement by psql's parser (which
  derives from the backend parser)

There are further tests that would be good to add. But even in the current
state it was rather useful for writing the fix in the prior commit.

Reviewed-by: Noah Misch <noah@leadboat.com>
Backpatch-through: 13
Security: CVE-2025-1094

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/01784793fca3d998dd36ea21f120a78f0b3d5e85

Modified Files
--------------
src/test/modules/Makefile                         |   1 +
src/test/modules/meson.build                      |   1 +
src/test/modules/test_escape/.gitignore           |   2 +
src/test/modules/test_escape/Makefile             |  27 +
src/test/modules/test_escape/meson.build          |  31 +
src/test/modules/test_escape/t/001_test_escape.pl |  53 ++
src/test/modules/test_escape/test_escape.c        | 803 ++++++++++++++++++++++
src/tools/msvc/Mkvcbuild.pm                       |   2 +-
src/tools/pgindent/typedefs.list                  |   3 +
9 files changed, 922 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Fix handling of invalidly encoded data in escaping functions
Next
From: Andres Freund
Date:
Subject: pgsql: Fix type in test_escape test