pgsql: Move PartitionPruneInfo out of plan nodes into PlannedStmt - Mailing list pgsql-committers

From Amit Langote
Subject pgsql: Move PartitionPruneInfo out of plan nodes into PlannedStmt
Date
Msg-id E1tdKlT-004KnS-LP@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Move PartitionPruneInfo out of plan nodes into PlannedStmt

This moves PartitionPruneInfo from plan nodes to PlannedStmt,
simplifying traversal by centralizing all PartitionPruneInfo
structures in a single list in it, which holds all instances for the
main query and its subqueries. Instead of plan nodes (Append or
MergeAppend) storing PartitionPruneInfo pointers, they now reference
an index in this list.

A bitmapset field is added to PartitionPruneInfo to store the RT
indexes corresponding to the apprelids field in Append or MergeAppend.
This allows execution pruning logic to verify that it operates on the
correct plan node, mainly to facilitate debugging.

Duplicated code in set_append_references() and
set_mergeappend_references() is refactored into a new function,
register_pruneinfo(). This updates RT indexes by applying rtoffet
and adds PartitionPruneInfo to the global list in PlannerGlobal.

By allowing pruning to be performed without traversing the plan tree,
this change lays the groundwork for runtime initial pruning to occur
independently of plan tree initialization.

Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org> (earlier version)
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Reviewed-by: Tomas Vondra <tomas@vondra.me>
Discussion: https://postgr.es/m/CA+HiwqFGkMSge6TgC9KQzde0ohpAycLQuV7ooitEEpbKB0O_mg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bb3ec16e14ded1d23a46d3c7e623a965164fa124

Modified Files
--------------
src/backend/executor/execMain.c         |   1 +
src/backend/executor/execParallel.c     |   1 +
src/backend/executor/execPartition.c    |  17 +++++-
src/backend/executor/execUtils.c        |   1 +
src/backend/executor/nodeAppend.c       |   5 +-
src/backend/executor/nodeMergeAppend.c  |   5 +-
src/backend/optimizer/plan/createplan.c |  23 +++----
src/backend/optimizer/plan/planner.c    |   1 +
src/backend/optimizer/plan/setrefs.c    | 103 +++++++++++++++++++-------------
src/backend/partitioning/partprune.c    |  19 ++++--
src/include/executor/execPartition.h    |   3 +-
src/include/nodes/execnodes.h           |   1 +
src/include/nodes/pathnodes.h           |   6 ++
src/include/nodes/plannodes.h           |  16 +++--
src/include/partitioning/partprune.h    |   8 +--
15 files changed, 137 insertions(+), 73 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Require callers of coerce_to_domain() to supply base type/typmod
Next
From: Amit Kapila
Date:
Subject: pgsql: Doc: Generated column replication.