pgsql: Use the correct sizeof() in BufFileLoadBuffer - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Use the correct sizeof() in BufFileLoadBuffer
Date
Msg-id E1tbUnV-003MEb-L0@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Use the correct sizeof() in BufFileLoadBuffer

The sizeof() call should reference buffer.data, because that's the
buffer we're reading data into, not the whole PGAlignedBuffer union.
This was introduced by 44cac93464, which replaced the simple buffer
with a PGAlignedBuffer field.

It's benign, because the buffer is the largest field of the union, so
the sizes are the same. But it's easy to trip over this in a patch, so
fix and backpatch. Commit 44cac93464 went into 12, but that's EOL.

Backpatch-through: 13
Discussion: https://postgr.es/m/928bdab1-6567-449f-98c4-339cd2203b87@vondra.me

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/38273b5f831bc7651fc479eacf3644e96a551af8

Modified Files
--------------
src/backend/storage/file/buffile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Jeff Davis
Date:
Subject: pgsql: Add SQL function CASEFOLD().
Next
From: Tomas Vondra
Date:
Subject: pgsql: Use the correct sizeof() in BufFileLoadBuffer