pgsql: Disallow NAMEDTUPLESTORE RTEs in stored views, rules, etc. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Disallow NAMEDTUPLESTORE RTEs in stored views, rules, etc.
Date
Msg-id E1tVdia-000YT8-JC@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Disallow NAMEDTUPLESTORE RTEs in stored views, rules, etc.

A named tuplestore is necessarily a transient object, so it makes
no sense to reference one in a persistent object such as a view.
We didn't previously prevent that, with the result that if you
tried you would get some weird failure about how the executor
couldn't find the tuplestore.

We can mechanize a check for this case cheaply by making dependency
extraction complain if it comes across such an RTE.  This is a
plausible way of dealing with it since part of the problem is that we
have no way to make a pg_depend representation of a named tuplestore.

Report and fix by Yugo Nagata.  Although this is an old problem,
it's a very weird corner case and there have been no reports from
end users.  So it seems sufficient to fix it in master.

Discussion: https://postgr.es/m/20240726160714.e74d0db579f2c017e1ca0b7e@sraoss.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3c49d462dbcfaff7bb77b1fec2c73c1079d25433

Modified Files
--------------
src/backend/catalog/dependency.c       | 15 +++++++++++++++
src/test/regress/expected/triggers.out | 20 ++++++++++++++++++++
src/test/regress/sql/triggers.sql      | 19 +++++++++++++++++++
3 files changed, 54 insertions(+)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Back-patch b1ffe3ff into REL_13_STABLE.
Next
From: Jeff Davis
Date:
Subject: pgsql: Move code for collation version into provider-specific files.