pgsql: Fix outdated CHUNKHDRSZ value in nodeAgg.c - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Fix outdated CHUNKHDRSZ value in nodeAgg.c
Date
Msg-id E1tTH7y-002cMJ-Al@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix outdated CHUNKHDRSZ value in nodeAgg.c

CHUNKHDRSZ was defined as 16 bytes, which was true when that code went in,
but since c6e0fe1f2, 8 is a more accurate value.  Here we adjust it to use
sizeof(MemoryChunk), which is normally 8, or 16 for cassert builds.

c6e0fe1f2 first appeared in v16, so this is technically wrong in v16 up
to master, but let's apply this only to master as adjusting this does
influence the estimated number of batches in the aggregate costing code
and we don't want to cause plan instability in released versions.

Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/CAApHDvpMpRQvsTqZo3FinXkgytwxwF8sCyZm83xDj-1s_hLe+w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d93bb8163c9cdbaa922ce6b1f3d044fc589d0fa6

Modified Files
--------------
src/backend/executor/nodeAgg.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Fix an assortment of spelling mistakes and typos
Next
From: Richard Guo
Date:
Subject: pgsql: Ignore nullingrels when looking up statistics