pgsql: jsonpath scanner: reentrant scanner - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: jsonpath scanner: reentrant scanner
Date
Msg-id E1tQDc8-001Axi-Ea@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
jsonpath scanner: reentrant scanner

Use the flex %option reentrant to make the generated scanner
reentrant and thread-safe.  Note: The parser was already pure.

Simplify flex scan buffer management: Instead of constructing the
buffer from pieces and then using yy_scan_buffer(), we can just use
yy_scan_string(), which does the same thing internally.  (Actually, we
use yy_scan_bytes() here because we already have the length.)

Use flex yyextra to handle context information, instead of global
variables.  This complements the other changes to make the scanner
reentrant.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reviewed-by: Andreas Karlsson <andreas@proxel.se>
Discussion: https://www.postgresql.org/message-id/flat/eb6faeac-2a8a-4b69-9189-c33c520e5b7b@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2a7425d7eef9b4b848763fb920fefa23c3c43f31

Modified Files
--------------
src/backend/nls.mk                        |   2 +-
src/backend/utils/adt/jsonpath_gram.y     |   2 +
src/backend/utils/adt/jsonpath_internal.h |  12 +-
src/backend/utils/adt/jsonpath_scan.l     | 283 ++++++++++++++----------------
4 files changed, 145 insertions(+), 154 deletions(-)


pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Fix nbtree symbol name comment reference.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: guc: reentrant scanner