pgsql: Make the memory layout of Port struct independent of USE_OPENSSL - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Make the memory layout of Port struct independent of USE_OPENSSL
Date
Msg-id E1tEWA2-0032yz-EA@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make the memory layout of Port struct independent of USE_OPENSSL

Commit d39a49c1e4 added new fields to the struct, but missed the "keep
these last" comment on the previous fields. Add placeholder variables
so that the offsets of the fields are the same whether you build with
USE_OPENSSL or not. This is a courtesy to extensions that might peek
at the fields, to make the ABI the same regardless of the options used
to build PostgreSQL.

In reality, I don't expect any extensions to look at the 'raw_buf'
fields. Firstly, they are new in v17, so no one's written such
extensions yet. Secondly, extensions should have no business poking at
those fields anyway. Nevertheless, fix this properly on 'master'. On
v17, we mustn't change the memory layout, so just fix the comments.

Author: Jacob Champion
Discussion:
https://www.postgresql.org/message-id/raw/CAOYmi%2BmKVJNzn5_TD_MK%3DhqO64r_w8Gb0FHCLk0oAkW-PJv8jQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8fb5936703e84945766b8425bfe54e0060dea231

Modified Files
--------------
src/include/libpq/libpq-be.h | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix data loss when restarting the bulk_write facility
Next
From: Nathan Bossart
Date:
Subject: pgsql: Add a couple of recent commits to .git-blame-ignore-revs.