pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus - Mailing list pgsql-committers

From Nathan Bossart
Subject pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus
Date
Msg-id E1sxvcJ-002bV6-N5@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
vacuumdb: Schema-qualify operator in catalog query's WHERE clause.

Commit 1ab67c9dfa, which modified this catalog query so that it
doesn't return temporary relations, forgot to schema-qualify the
operator.  A comment earlier in the function implores us to fully
qualify everything in the query:

         * Since we execute the constructed query with the default search_path
         * (which could be unsafe), everything in this query MUST be fully
         * qualified.

This commit fixes that.  While at it, add a newline for consistency
with surrounding code.

Reviewed-by: Noah Misch
Discussion: https://postgr.es/m/ZwQJYcuPPUsF0reU%40nathan
Backpatch-through: 12

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/eba8cc1af8ec57aff99f11ef9cdf24a641c159b0

Modified Files
--------------
src/bin/scripts/vacuumdb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: Fix Y2038 issues with MyStartTime.
Next
From: Nathan Bossart
Date:
Subject: pgsql: Fix test for password hash length limit.