pgsql: Propagate query IDs of utility statements in functions - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Propagate query IDs of utility statements in functions
Date
Msg-id E1sUcJq-000CZ3-Kp@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Propagate query IDs of utility statements in functions

For utility statements defined within a function, the query tree is
copied to a PlannedStmt as utility commands do not require planning.
However, the query ID was missing from the information passed down.

This leads to plugins relying on the query ID like pg_stat_statements to
not be able to track utility statements within function calls.  Tests
are added to check this behavior, depending on pg_stat_statements.track.

This is an old bug.  Now, query IDs for utilities are compiled using
their parsed trees rather than the query string since v16
(3db72ebcbe20), leading to less bloat with utilities, so backpatch down
only to this version.

Author: Anthonin Bonnefoy
Discussion: https://postgr.es/m/CAO6_XqrGp-uwBqi3vBPLuRULKkddjC7R5QZCgsFren=8E+m2Sg@mail.gmail.com
Backpatch-through: 16

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c145f321b681ab6c3636849071ff30d5c6f6353c

Modified Files
--------------
.../pg_stat_statements/expected/level_tracking.out | 45 ++++++++++++++++++++++
contrib/pg_stat_statements/sql/level_tracking.sql  | 22 +++++++++++
src/backend/executor/functions.c                   |  1 +
3 files changed, 68 insertions(+)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Improve pg_ctl's message for shutdown after recovery.
Next
From: Etsuro Fujita
Date:
Subject: pgsql: postgres_fdw: Avoid "cursor can only scan forward" error.