pgsql: Make pg_createsubscriber more wary about quoting connection para - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Make pg_createsubscriber more wary about quoting connection para
Date
Msg-id E1sNycE-003gh4-EE@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make pg_createsubscriber more wary about quoting connection parameters.

The original coding here could fail with database names, user names,
etc that contain spaces or other special characters.

As partial test coverage, extend the 040_pg_createsubscriber.pl
test script so that it uses a generated database name containing
funny characters.

Hayato Kuroda (some mods by me), per complaint from Noah Misch

Discussion: https://postgr.es/m/20240623062157.97.nmisch@google.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b3f5ccebd79d9c7b73f4e04611cdf31fdf87420b

Modified Files
--------------
src/bin/pg_basebackup/pg_createsubscriber.c        |  53 ++++++----
src/bin/pg_basebackup/t/040_pg_createsubscriber.pl | 111 ++++++++++++---------
2 files changed, 96 insertions(+), 68 deletions(-)


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: pgsql: Fix .gitignore for new injection suite.
Next
From: Tom Lane
Date:
Subject: pgsql: Make pg_createsubscriber warn if publisher has two-phase commit