pgsql: Expand comments and add an assertion in nodeModifyTable.c. - Mailing list pgsql-committers

From Noah Misch
Subject pgsql: Expand comments and add an assertion in nodeModifyTable.c.
Date
Msg-id E1sN1KA-003J0P-7b@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Expand comments and add an assertion in nodeModifyTable.c.

Most comments concern RELKIND_VIEW.  One addresses the ExecUpdate()
"tupleid" parameter.  A later commit will rely on these facts, but they
hold already.  Back-patch to v12 (all supported versions), the plan for
that commit.

Reviewed (in an earlier version) by Robert Haas.

Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c3437fb7255b1ad7b19c9d6149919b60daa9bb1d

Modified Files
--------------
src/backend/executor/nodeModifyTable.c | 24 +++++++++++++++++-------
1 file changed, 17 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: pgsql: Make TAP todo_start effects the same under Meson and prove_check
Next
From: Michael Paquier
Date:
Subject: pgsql: Improve locking around InjectionPointRun()