pgsql: Fix ON CONFLICT DO NOTHING/UPDATE for temporal indexes - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Fix ON CONFLICT DO NOTHING/UPDATE for temporal indexes
Date
Msg-id E1s5Q21-000KWK-GE@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix ON CONFLICT DO NOTHING/UPDATE for temporal indexes

A PRIMARY KEY or UNIQUE constraint with WITHOUT OVERLAPS will be a
GiST index, not a B-Tree, but it will still have indisunique set.  The
code for ON CONFLICT fails if it sees a non-btree index that has
indisunique.  This commit fixes that and adds some tests.  But now
that we can't just test indisunique, we also need some extra checks to
prevent DO UPDATE from running against a WITHOUT OVERLAPS constraint
(because the conflict could happen against more than one row, and we'd
only update one).

Author: Paul A. Jungwirth <pj@illuminatedcomputing.com>
Discussion: https://www.postgresql.org/message-id/1426589a-83cb-4a89-bf40-713970c07e63@illuminatedcomputing.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/144c2ce0cc75ff99c66749b0ca5235d037df7c09

Modified Files
--------------
src/backend/executor/execIndexing.c            |   2 +-
src/backend/optimizer/util/plancat.c           |   9 +-
src/test/regress/expected/without_overlaps.out | 176 +++++++++++++++++++++++++
src/test/regress/sql/without_overlaps.sql      | 113 ++++++++++++++++
4 files changed, 298 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Doc: update the "Using EXPLAIN" examples to match current code.
Next
From: Bruce Momjian
Date:
Subject: pgsql: doc PG 17 relnotes: add FETCH_COUNT item