pgsql: Avoid repeating loads of frozen ID values. - Mailing list pgsql-committers

From Noah Misch
Subject pgsql: Avoid repeating loads of frozen ID values.
Date
Msg-id E1s1Upr-000eAB-TW@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid repeating loads of frozen ID values.

Repeating loads of inplace-updated fields tends to cause bugs like the
one from the previous commit.  While there's no bug to fix in these code
sites, adopt the load-once style.  This improves the chance of future
copy/paste finding the safe style.

Discussion: https://postgr.es/m/20240423003956.e7.nmisch@google.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dd0183469bb779247c96e86c2272dca7ff4ec9e7

Modified Files
--------------
src/backend/access/heap/heapam.c    | 16 ++++++++++------
src/backend/commands/cluster.c      | 22 ++++++++++++++--------
src/backend/commands/vacuum.c       |  4 ++--
src/backend/postmaster/autovacuum.c | 13 ++++++++-----
4 files changed, 34 insertions(+), 21 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: libpq: Enforce ALPN in direct SSL connections
Next
From: Noah Misch
Date:
Subject: pgsql: Close race condition between datfrozen and relfrozen updates.