pgsql: Allow using copy_file_range in write_reconstructed_file - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Allow using copy_file_range in write_reconstructed_file
Date
Msg-id E1rsnJl-000fLD-J7@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Allow using copy_file_range in write_reconstructed_file

This commit allows using copy_file_range() for efficient combining of
data from multiple files, instead of simply reading/writing the blocks.
Depending on the filesystem and other factors (size of the increment,
distribution of modified blocks etc.) this may be faster than the
block-by-block copy, but more importantly it enables various features
provided by CoW filesystems.

If a checksum needs to be calculated for the file, the same strategy as
when copying whole files is used - copy_file_range is used to copy the
blocks, but the file is also read for the checksum calculation.

While the checksum calculation is rarely needed when cloning whole
files, when reconstructing the files from multiple backups it needs to
happen almost always (the only exception is when the user specified
--no-manifest).

Author: Tomas Vondra
Reviewed-by: Thomas Munro, Jakub Wartak, Robert Haas
Discussion: https://postgr.es/m/3024283a-7491-4240-80d0-421575f6bb23%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ac81101551326ddf4c5cb804c75bd3e8c56506ba

Modified Files
--------------
src/bin/pg_combinebackup/reconstruct.c | 134 ++++++++++++++++++++++++++-------
1 file changed, 106 insertions(+), 28 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: [MASSMAIL]pgsql: Make libpqsrv_cancel's return const char *, not char *
Next
From: Tomas Vondra
Date:
Subject: pgsql: Check HAVE_COPY_FILE_RANGE before calling copy_file_range