pgsql: Allow "make check"-style testing to work with musl C library. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Allow "make check"-style testing to work with musl C library.
Date
Msg-id E1rp8yx-005mXy-Bf@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Allow "make check"-style testing to work with musl C library.

The musl dynamic linker saves a pointer to the process' environment
value of LD_LIBRARY_PATH very early in startup.  When we move/clobber
the environment to make more room for ps status strings, we clobber
that value and thereby prevent libraries from being found via
LD_LIBRARY_PATH, which breaks the use of a temporary installation
for testing purposes.  To fix, stop collecting usable space for
ps status if we notice that the variable we are about to clobber
is LD_LIBRARY_PATH.  This will result in some reduction in how long
the ps status can be, but it's only likely to occur in temporary
test contexts, so it doesn't seem like a big problem.  In any case,
we don't have to do it if we see we are on glibc, which surely is
where the majority of our Linux testing is done.

Thomas Munro, Bruce Momjian, and Tom Lane, per report from Wolfgang
Walther.  Back-patch to all supported branches, with the hope that
we'll set up a buildfarm animal to test on this platform.

Discussion: https://postgr.es/m/fddd1cd6-dc16-40a2-9eb5-d7fef2101488@technowledgy.de

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/243e9953281f680037eb65ee638b030424b84947

Modified Files
--------------
src/backend/utils/misc/ps_status.c | 35 +++++++++++++++++++++++++++++++----
1 file changed, 31 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: pgsql: make dist uses git archive
Next
From: Bruce Momjian
Date:
Subject: pgsql: C comment: mention no doc for negative start of substring(text)