pgsql: Fix convert_case(), introduced in 5c40364dd6. - Mailing list pgsql-committers

From Jeff Davis
Subject pgsql: Fix convert_case(), introduced in 5c40364dd6.
Date
Msg-id E1roXRt-005UTF-P0@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix convert_case(), introduced in 5c40364dd6.

Check source length before checking for NUL terminator to avoid
reading one byte past the string end. Also fix unreachable bug when
caller does not expect NUL-terminated result.

Add unit test coverage of convert_case() in case_test.c, which makes
it easier to reproduce the valgrind failure.

Discussion: https://postgr.es/m/7a9fd36d-7a38-4dc2-e676-fc939491a95a@gmail.com
Reported-by: Alexander Lakhin

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/503c0ad976f5e4ada2d1b47ae05aa7133351b645

Modified Files
--------------
src/common/unicode/case_test.c | 101 +++++++++++++++++++++++++++++++++++++++--
src/common/unicode_case.c      |   6 +--
2 files changed, 101 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: doc: Clarify requirements for SET ROLE.
Next
From: Alexander Korotkov
Date:
Subject: pgsql: reindexdb: Add the index-level REINDEX with multiple jobs