pgsql: Fix wrong logic in TransactionIdInRecentPast() - Mailing list pgsql-committers

From Alexander Korotkov
Subject pgsql: Fix wrong logic in TransactionIdInRecentPast()
Date
Msg-id E1rYOGM-005NSC-GU@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix wrong logic in TransactionIdInRecentPast()

The TransactionIdInRecentPast() should return false for all the transactions
older than TransamVariables->oldestClogXid.  However, the function contains
a bug in comparison FullTransactionId to TransactionID allowing full
transactions between nextXid - 2^32 and oldestClogXid - 2^31.

This commit fixes TransactionIdInRecentPast() by turning the oldestClogXid into
FullTransactionId first, then performing the comparison.

Backpatch to all supported versions.

Reported-by: Egor Chindyaskin
Bug: 18212
Discussion: https://postgr.es/m/18212-547307f8adf57262%40postgresql.org
Author: Karina Litskevich
Reviewed-by: Kyotaro Horiguchi
Backpatch-through: 12

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e3e05addee42c643867557a3065debb085f1d169

Modified Files
--------------
src/backend/utils/adt/xid8funcs.c | 30 +++++++++++++++++++-----------
1 file changed, 19 insertions(+), 11 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Fix propagation of persistence to sequences in ALTER TABLE / ADD
Next
From: Alexander Korotkov
Date:
Subject: pgsql: Fix wrong logic in TransactionIdInRecentPast()