pgsql: Guard against overflow in make_interval(). - Mailing list pgsql-committers

From Dean Rasheed
Subject pgsql: Guard against overflow in make_interval().
Date
Msg-id E1qx87C-002yRD-CA@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Guard against overflow in make_interval().

The original code did very little to guard against integer or floating
point overflow when computing the interval's fields.  Detect any such
overflows and error out, rather than silently returning bogus results.

Joseph Koshakow, reviewed by Ashutosh Bapat and me.

Discussion: https://postgr.es/m/CAAvxfHcm1TPwH_zaGWuFoL8pZBestbRZTU6Z%3D-RvAdSXTPbKfg%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b2d55447a563036579d6777f64a7483dceeab6ea

Modified Files
--------------
src/backend/utils/adt/timestamp.c      | 39 ++++++++++++++++++++++++----------
src/include/datatype/timestamp.h       |  1 +
src/test/regress/expected/interval.out | 27 +++++++++++++++++++++++
src/test/regress/sql/interval.sql      | 15 +++++++++++++
4 files changed, 71 insertions(+), 11 deletions(-)


pgsql-committers by date:

Previous
From: Dean Rasheed
Date:
Subject: pgsql: btree_gin: Fix calculation of leftmost interval value.
Next
From: Tom Lane
Date:
Subject: pgsql: Teach pg_dump about the new pg_subscription.subrunasowner option