pgsql: Fix intra-query memory leak when a SRF returns zero rows. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix intra-query memory leak when a SRF returns zero rows.
Date
Msg-id E1qwngS-002nnH-4y@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix intra-query memory leak when a SRF returns zero rows.

When looping around after finding that the set-returning function
returned zero rows for the current input tuple, ExecProjectSet
neglected to reset either of the two memory contexts it's
responsible for cleaning out.  Typically this wouldn't cause much
problem, because once the SRF does return at least one row, the
contexts would get reset on the next call.  However, if the SRF
returns no rows for many input tuples in succession, quite a lot
of memory could be transiently consumed.

To fix, make sure we reset both contexts while looping around.

Per bug #18172 from Sergei Kornilov.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/18172-9b8c5fc1d676ded3@postgresql.org

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/07494a0df9a66219e5f1029de47ecabc34c9cb55

Modified Files
--------------
src/backend/executor/nodeProjectSet.c | 26 +++++++++++++++++---------
1 file changed, 17 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: doc: add links to Postgres features intro
Next
From: Dean Rasheed
Date:
Subject: pgsql: btree_gin: Fix calculation of leftmost interval value.