pgsql: Fix small overestimation of base64 encoding output length. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix small overestimation of base64 encoding output length.
Date
Msg-id E1q7HVA-000m6h-O7@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix small overestimation of base64 encoding output length.

pg_base64_enc_len() and its clones overestimated the output
length by up to 2 bytes, as a result of sloppy thinking about
where to divide.  No callers require a precise estimate, so
this has no consequences worse than palloc'ing a byte or two
more than necessary.  We might as well get it right though.

This bug is very ancient, dating to commit 79d78bb26 which
added encode.c.  (The other instances were presumably copied
from there.)  Still, it doesn't quite seem worth back-patching.

Oleg Tselebrovskiy

Discussion: https://postgr.es/m/f94da55286a63022150bc266afdab754@postgrespro.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d98ed080bb31fd3d46281127871b7886288686d9

Modified Files
--------------
contrib/pgcrypto/pgp-armor.c   | 2 +-
src/backend/utils/adt/encode.c | 2 +-
src/common/base64.c            | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: pgsql: doc: Fix example command for ALTER FOREIGN TABLE ... OPTIONS.
Next
From: Tom Lane
Date:
Subject: pgsql: Re-allow INDEX_VAR as rt_index in ChangeVarNodes().