pgsql: Fix overridden callbacks in pg_rewind. - Mailing list pgsql-committers

From Daniel Gustafsson
Subject pgsql: Fix overridden callbacks in pg_rewind.
Date
Msg-id E1pto6q-0006Qx-GS@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix overridden callbacks in pg_rewind.

The <source>_traverse_files functions take a callback for processing
files, but both the local and libpq source implementations called the
function directly without using the callback argument. While there is
no bug right now as the function called is the same as the callback,
fix by calling the callback to reduce the risk of subtle bugs in the
future.

Author: Junwang Zhao <zhjwpku@gmail.com>
Reviewed-by: Richard Guo <guofenglinux@gmail.com>
Discussion: https://postgr.es/m/CAEG8a3Jdwgh+PZr2zh1=t8apA4Yz8tKq+uubPqoCt14nvWKHEw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/08237056f84e3a9ed75e8a698428c669f4d35db4

Modified Files
--------------
src/bin/pg_rewind/libpq_source.c | 2 +-
src/bin/pg_rewind/local_source.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Update SQL features
Next
From: Tom Lane
Date:
Subject: pgsql: Doc: clarify behavior of row-limit arguments in the PLs' SPI wra