pgsql: Fix recent pg_walinspect fpi_length bug. - Mailing list pgsql-committers

From Peter Geoghegan
Subject pgsql: Fix recent pg_walinspect fpi_length bug.
Date
Msg-id E1phDXO-000BYd-PD@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix recent pg_walinspect fpi_length bug.

Commit 0276ae42dd taught pg_walinspect's pg_get_wal_record_info()
function to output NULLs rather than empty strings for its record
description and block_ref output parameters.  However, it inadvertently
moved the function call that sets fpi_length until after it was already
set.  As a result, pg_get_wal_record_info() always output spurious
fpi_length values of 0.

Fix by switching the order back (but keep the behavioral change).

Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Discussion: https://postgr.es/m/CAH2-WzkJmgSYkt6-smQ+57SxSmov+EKqFZdSimFewosoL_JKoA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bade01cb4dd88f63bd9024cfdaec3d5001a805f3

Modified Files
--------------
contrib/pg_walinspect/pg_walinspect.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix corner-case planner failure for MERGE.
Next
From: Robert Haas
Date:
Subject: pgsql: amcheck: In verify_heapam, allows tuples with xmin 0.