pgsql: postgres_fdw: Remove useless if-test in GetConnection(). - Mailing list pgsql-committers

From Etsuro Fujita
Subject pgsql: postgres_fdw: Remove useless if-test in GetConnection().
Date
Msg-id E1pd6HP-003xz7-UB@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
postgres_fdw: Remove useless if-test in GetConnection().

Checking whether entry->conn is NULL after doing disconnect_pg_server()
for that entry is pointless, as that function ensures that it is NULL.

Thinko in commit 7fc1a81e4; this would be harmless, so patch HEAD only.

Reviewed-by: Richard Guo and Daniel Gustafsson
Discussion: https://postgr.es/m/CAPmGK169vQ83PQwQkoxO-AK2EeK1EsgsxixedM%2BBLWEAhZ_AqQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/39a3bdc9eba50628cecb7e3cada95271180c8744

Modified Files
--------------
contrib/postgres_fdw/connection.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: libpq: Use modern socket flags, if available.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Improve several permission-related error messages.