pgsql: Fix corner case bug in numeric to_char() some more. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix corner case bug in numeric to_char() some more.
Date
Msg-id E1pcDtq-003ZWJ-7W@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix corner case bug in numeric to_char() some more.

The band-aid applied in commit f0bedf3e4 turns out to still need
some work: it made sure we didn't set Np->last_relevant too small
(to the left of the decimal point), but it didn't prevent setting
it too large (off the end of the partially-converted string).
This could result in fetching data beyond the end of the allocated
space, which with very bad luck could cause a SIGSEGV, though
I don't see any hazard of interesting memory disclosure.

Per bug #17839 from Thiago Nunes.  The bug's pretty ancient,
so back-patch to all supported versions.

Discussion: https://postgr.es/m/17839-aada50db24d7b0da@postgresql.org

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/386a26023afb624726fb756ffdbef5b5832caa96

Modified Files
--------------
src/backend/utils/adt/formatting.c    | 11 +++++++++--
src/test/regress/expected/numeric.out |  6 ++++++
src/test/regress/sql/numeric.sql      |  1 +
3 files changed, 16 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Allow pg_dump to include/exclude child tables automatically.
Next
From: Thomas Munro
Date:
Subject: pgsql: Fix waitpid() emulation on Windows.