pgsql: libpq: Add support for require_auth to control authorized auth m - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: libpq: Add support for require_auth to control authorized auth m
Date
Msg-id E1pbwmD-003Rqr-6b@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
libpq: Add support for require_auth to control authorized auth methods

The new connection parameter require_auth allows a libpq client to
define a list of comma-separated acceptable authentication types for use
with the server.  There is no negotiation: if the server does not
present one of the allowed authentication requests, the connection
attempt done by the client fails.

The following keywords can be defined in the list:
- password, for AUTH_REQ_PASSWORD.
- md5, for AUTH_REQ_MD5.
- gss, for AUTH_REQ_GSS[_CONT].
- sspi, for AUTH_REQ_SSPI and AUTH_REQ_GSS_CONT.
- scram-sha-256, for AUTH_REQ_SASL[_CONT|_FIN].
- creds, for AUTH_REQ_SCM_CREDS (perhaps this should be removed entirely
now).
- none, to control unauthenticated connections.

All the methods that can be defined in the list can be negated, like
"!password", in which case the server must NOT use the listed
authentication type.  The special method "none" allows/disallows the use
of unauthenticated connections (but it does not govern transport-level
authentication via TLS or GSSAPI).

Internally, the patch logic is tied to check_expected_areq(), that was
used for channel_binding, ensuring that an incoming request is
compatible with conn->require_auth.  It also introduces a new flag,
conn->client_finished_auth, which is set by various authentication
routines when the client side of the handshake is finished.  This
signals to check_expected_areq() that an AUTH_REQ_OK from the server is
expected, and allows the client to complain if the server bypasses
authentication entirely, with for example the reception of a too-early
AUTH_REQ_OK message.

Regression tests are added in authentication TAP tests for all the
keywords supported (except "creds", because it is around only for
compatibility reasons).  A new TAP script has been added for SSPI, as
there was no script dedicated to it yet.  It relies on SSPI being the
default authentication method on Windows, as set by pg_regress.

Author: Jacob Champion
Reviewed-by: Peter Eisentraut, David G. Johnston, Michael Paquier
Discussion: https://postgr.es/m/9e5a8ccddb8355ea9fa4b75a1e3a9edc88a70cd3.camel@vmware.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3a465cc6783f586096d9f885c3fc544d82eb8f19

Modified Files
--------------
doc/src/sgml/libpq.sgml                   | 115 +++++++++++++++
src/include/libpq/pqcomm.h                |   1 +
src/interfaces/libpq/fe-auth-scram.c      |   1 +
src/interfaces/libpq/fe-auth.c            | 139 ++++++++++++++++++
src/interfaces/libpq/fe-connect.c         | 170 ++++++++++++++++++++++
src/interfaces/libpq/libpq-int.h          |   9 ++
src/test/authentication/meson.build       |   1 +
src/test/authentication/t/001_password.pl | 232 ++++++++++++++++++++++++++++++
src/test/authentication/t/005_sspi.pl     |  41 ++++++
src/test/kerberos/t/001_auth.pl           |  36 +++++
src/test/ldap/t/001_auth.pl               |   6 +
src/test/ssl/t/002_scram.pl               |  28 ++++
12 files changed, 779 insertions(+)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: meson: fix openssl detection issues in 6a30027
Next
From: Dean Rasheed
Date:
Subject: pgsql: Add support for the error functions erf() and erfc().