pgsql: Revise pg_pwrite_zeros() - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Revise pg_pwrite_zeros()
Date
Msg-id E1pZ2MD-0028J0-2W@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Revise pg_pwrite_zeros()

The following changes are made to pg_write_zeros(), the API able to
write series of zeros using vectored I/O:
- Add of an "offset" parameter, to write the size from this position
(the 'p' of "pwrite" seems to mean position, though POSIX does not
outline ythat directly), hence the name of the routine is incorrect if
it is not able to handle offsets.
- Avoid memset() of "zbuffer" on every call.
- Avoid initialization of the whole IOV array if not needed.
- Group the trailing write() call with the main write() call,
simplifying the function logic.

Author: Andres Freund
Reviewed-by: Michael Paquier, Bharath Rupireddy
Discussion: https://postgr.es/m/20230215005525.mrrlmqrxzjzhaipl@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ce340e530d1f76367379a8d230ad5f411e5f25d2

Modified Files
--------------
src/backend/access/transam/xlog.c  |  2 +-
src/bin/pg_basebackup/walmethods.c |  2 +-
src/common/file_utils.c            | 62 +++++++++++++-------------------------
src/include/common/file_utils.h    |  2 +-
4 files changed, 24 insertions(+), 44 deletions(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Fix assert failures in parallel SERIALIZABLE READ ONLY.
Next
From: Amit Kapila
Date:
Subject: pgsql: Deduplicate handling of binary and text modes in logicalrep_read