pgsql: Properly NULL-terminate GSS receive buffer on error packet recep - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Properly NULL-terminate GSS receive buffer on error packet recep
Date
Msg-id E1pOrAF-001nTo-Ij@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Properly NULL-terminate GSS receive buffer on error packet reception

pqsecure_open_gss() includes a code path handling error messages with
v2-style protocol messages coming from the server.  The client-side
buffer holding the error message does not force a NULL-termination, with
the data of the server getting copied to the errorMessage of the
connection.  Hence, it would be possible for a server to send an
unterminated string and copy arbitrary bytes in the buffer receiving the
error message in the client, opening the door to a crash or even data
exposure.

As at this stage of the authentication process the exchange has not been
completed yet, this could be abused by an attacker without Kerberos
credentials.  Clients that have a valid kerberos cache are vulnerable as
libpq opportunistically requests for it except if gssencmode is
disabled.

Author: Jacob Champion
Backpatch-through: 12
Security: CVE-2022-41862

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/45a945ee97b8b55a45d2ff5d4f4944b1e2dcacb8

Modified Files
--------------
src/interfaces/libpq/fe-secure-gssapi.c | 2 ++
1 file changed, 2 insertions(+)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Revert refactoring of restore command code to shell_restore.c
Next
From: Robins Tharakan
Date:
Subject: Re: pgsql: Do assorted mop-up in the planner.