pgsql: Retire PG_SETMASK() macro. - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Retire PG_SETMASK() macro.
Date
Msg-id E1pNi7d-001Hek-RD@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Retire PG_SETMASK() macro.

In the 90s we needed to deal with computers that still had the
pre-standard signal masking APIs.  That hasn't been relevant for a very
long time on Unix systems, and c94ae9d8 got rid of a remaining
dependency in our Windows porting code.  PG_SETMASK didn't expose
save/restore functionality, so we'd already started using sigprocmask()
directly in places, creating the visual distraction of having two ways
to spell it.  It's not part of the API that extensions are expected to
be using (but if they are, the change will be trivial).  It seems like a
good time to drop the old macro and just call the standard POSIX
function.

Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Discussion: https://postgr.es/m/CA%2BhUKG%2BKfQgrhHP2DLTohX1WwubaCBHmTzGnAEDPZ-Gug-Xskg%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cdf6518ef08ee602b94db4e5ba5887a1d7053c24

Modified Files
--------------
src/backend/access/transam/xact.c     |  4 ++--
src/backend/postmaster/autovacuum.c   |  4 ++--
src/backend/postmaster/bgworker.c     |  2 +-
src/backend/postmaster/bgwriter.c     |  2 +-
src/backend/postmaster/checkpointer.c |  2 +-
src/backend/postmaster/pgarch.c       |  2 +-
src/backend/postmaster/postmaster.c   | 12 ++++++------
src/backend/postmaster/startup.c      |  2 +-
src/backend/postmaster/syslogger.c    |  2 +-
src/backend/postmaster/walwriter.c    |  2 +-
src/backend/replication/walreceiver.c |  2 +-
src/backend/tcop/postgres.c           |  4 ++--
src/backend/utils/init/miscinit.c     |  4 ++--
src/include/libpq/pqsignal.h          |  2 --
14 files changed, 22 insertions(+), 24 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Do assorted mop-up in the planner.
Next
From: David Rowley
Date:
Subject: pgsql: Further refactor of heapgettup and heapgettup_pagemode