pgsql: libpqwalreceiver: Convert to libpq-be-fe-helpers.h - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: libpqwalreceiver: Convert to libpq-be-fe-helpers.h
Date
Msg-id E1pK9xm-005Awo-He@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
libpqwalreceiver: Convert to libpq-be-fe-helpers.h

In contrast to the changes to dblink and postgres_fdw, this does not fix a
bug, as libpqwalreceiver did already process interrupts.

Besides reducing code duplication, the conversion leads to libpqwalreceiver
now using reserving file descriptors for libpq connections. While not strictly
required for the use in walreceiver, we are also using libpqwalreceiver for
logical replication, where it does seem more important.

Even if we eventually decide to backpatch the prior commits, there'd be no
need to backpatch this commit, due to not fixing an active bug.

Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/20220925232237.p6uskba2dw6fnwj2@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/728f86fec65537eade8d9e751961782ddb527934

Modified Files
--------------
.../libpqwalreceiver/libpqwalreceiver.c            | 53 +++-------------------
1 file changed, 7 insertions(+), 46 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Fix error handling in libpqrcv_connect()
Next
From: Amit Kapila
Date:
Subject: pgsql: Fix the Drop Database hang.