pgsql: Add missing assign hook for GUC checkpoint_completion_target - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Add missing assign hook for GUC checkpoint_completion_target
Date
Msg-id E1pIMKO-004OIa-2Y@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add missing assign hook for GUC checkpoint_completion_target

This is wrong since 88e9823, that has switched the WAL sizing
configuration from checkpoint_segments to min_wal_size and
max_wal_size.  This missed the recalculation of the internal value of
the internal "CheckPointSegments", that works as a mapping of the old
GUC checkpoint_segments, on reload, for example, and it controls the
timing of checkpoints depending on the volume of WAL generated.

Most users tend to leave checkpoint_completion_target at 0.9 to smooth
the I/O workload, which is why I guess this has gone unnoticed for so
long, still it can be useful to tweak and reload the value dynamically
in some cases to control the timing of checkpoints.

Author: Bharath Rupireddy
Discussion: https://postgr.es/m/CALj2ACXgPPAm28mruojSBno+F_=9cTOOxHAywu_dfZPeBdybQw@mail.gmail.com
Backpatch-through: 11

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/49e3a5e7149d3f676318f2222aaab30613f8dc59

Modified Files
--------------
src/backend/utils/misc/guc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix failure with perlcritic in psql's create_help.pl
Next
From: Michael Paquier
Date:
Subject: pgsql: doc: Fix some issues in logical replication section