pgsql: Get rid of the "new" and "old" entries in a view's rangetable. - Mailing list pgsql-committers
| From | Tom Lane |
|---|---|
| Subject | pgsql: Get rid of the "new" and "old" entries in a view's rangetable. |
| Date | |
| Msg-id | E1pFlej-003Cfo-Dr@gemulon.postgresql.org Whole thread Raw |
| List | pgsql-committers |
Get rid of the "new" and "old" entries in a view's rangetable. The rule system needs "old" and/or "new" pseudo-RTEs in rule actions that are ON INSERT/UPDATE/DELETE. Historically it's put such entries into the ON SELECT rules of views as well, but those are really quite vestigial. The only thing we've used them for is to carry the view's relid forward to AcquireExecutorLocks (so that we can re-lock the view to verify it hasn't changed before re-using a plan) and to carry its relid and permissions data forward to execution-time permissions checks. What we can do instead of that is to retain these fields of the RTE_RELATION RTE for the view even after we convert it to an RTE_SUBQUERY RTE. This requires a tiny amount of extra complication in the planner and AcquireExecutorLocks, but on the other hand we can get rid of the logic that moves that data from one place to another. The principal immediate benefit of doing this, aside from a small saving in the pg_rewrite data for views, is that these pseudo-RTEs no longer trigger ruleutils.c's heuristic about qualifying variable names when the rangetable's length is more than 1. That results in quite a number of small simplifications in regression test outputs, which are all to the good IMO. Bump catversion because we need to dump a few more fields of RTE_SUBQUERY RTEs. While those will always be zeroes anyway in stored rules (because we'd never populate them until query rewrite) they are useful for debugging, and it seems like we'd better make sure to transmit such RTEs accurately in plans sent to parallel workers. I don't think the executor actually examines these fields after startup, but someday it might. Amit Langote Discussion: https://postgr.es/m/CA+HiwqEf7gPN4Hn+LoZ4tP2q_Qt7n3vw7-6fJKOf92tSEnX6Gg@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1b4d280ea1eb7ddb2e16654d5fa16960bb959566 Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 16 +- src/backend/commands/lockcmds.c | 9 - src/backend/commands/view.c | 107 ---- src/backend/nodes/outfuncs.c | 7 +- src/backend/nodes/readfuncs.c | 7 +- src/backend/optimizer/plan/setrefs.c | 26 +- src/backend/parser/parse_relation.c | 2 +- src/backend/rewrite/rewriteDefine.c | 7 - src/backend/rewrite/rewriteHandler.c | 38 +- src/backend/utils/cache/plancache.c | 3 +- src/bin/pg_dump/t/002_pg_dump.pl | 12 +- src/include/catalog/catversion.h | 2 +- src/include/nodes/parsenodes.h | 18 +- src/test/regress/expected/aggregates.out | 26 +- src/test/regress/expected/alter_table.out | 16 +- src/test/regress/expected/collate.icu.utf8.out | 24 +- src/test/regress/expected/collate.linux.utf8.out | 24 +- src/test/regress/expected/collate.out | 26 +- src/test/regress/expected/compression.out | 4 +- src/test/regress/expected/create_view.out | 222 +++---- src/test/regress/expected/expressions.out | 24 +- src/test/regress/expected/groupingsets.out | 20 +- src/test/regress/expected/limit.out | 24 +- src/test/regress/expected/matview.out | 24 +- src/test/regress/expected/polymorphism.out | 8 +- src/test/regress/expected/rangefuncs.out | 34 +- src/test/regress/expected/rules.out | 748 +++++++++++------------ src/test/regress/expected/tablesample.out | 4 +- src/test/regress/expected/triggers.out | 4 +- src/test/regress/expected/updatable_views.out | 78 +-- src/test/regress/expected/window.out | 56 +- src/test/regress/expected/with.out | 32 +- src/test/regress/expected/xml.out | 6 +- src/test/regress/expected/xml_2.out | 6 +- 34 files changed, 774 insertions(+), 890 deletions(-)
pgsql-committers by date: