pgsql: Update upgrade_adapt.sql to handle tables using aclitem as data - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Update upgrade_adapt.sql to handle tables using aclitem as data
Date
Msg-id E1p8Xw0-004y9D-Li@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Update upgrade_adapt.sql to handle tables using aclitem as data type

The regression test suite includes a table called "tab_core_types" that
has one attribute based on the type "aclitem".  Keeping this attribute
as-is causes hard failures when running pg_upgrade with an origin on
~15.  This commit updates upgrade_adapt.sql to automatically detect the
tables with such attributes and switch them to text so as pg_upgrade
is able to go through its run.

This does not provide the same detection coverage as pg_upgrade, where
we are able to find out aclitems used in arrays, domains or even
composite types, but this is (I guess) enough for most things like an
instance that had installcheck run on before the upgrade with a dump
generated from it.

Note that the buildfarm code has taken the simplest approach of just
dropping "tab_core_types", so what we have here is more modular.

Author: Anton A. Melnikov
Discussion: https://postgr.es/m/49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f4f2f2b84a0bbf9edbfc4a8684040a941cd6d085

Modified Files
--------------
src/bin/pg_upgrade/upgrade_adapt.sql | 30 +++++++++++++++++++++++++++++-
1 file changed, 29 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI
Next
From: Thomas Munro
Date:
Subject: pgsql: Add WL_SOCKET_ACCEPT event to WaitEventSet API.