pgsql: Fix broken MemoizePath support in reparameterize_path(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix broken MemoizePath support in reparameterize_path().
Date
Msg-id E1p1u2U-001zzI-DM@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix broken MemoizePath support in reparameterize_path().

It neglected to recurse to the subpath, meaning you'd get back
a path identical to the input.  This could produce wrong query
results if the omission meant that the subpath fails to enforce
some join clause it should be enforcing.  We don't have a test
case for this at the moment, but the code is obviously broken
and the fix is equally obvious.  Back-patch to v14 where
Memoize was introduced.

Richard Guo

Discussion: https://postgr.es/m/CAMbWs4_R=ORpz=Lkn2q3ebPC5EuWyfZF+tmfCPVLBVK5W39mHA@mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ce093aa18062f64d5eb16175e361cc34a222c1db

Modified Files
--------------
src/backend/optimizer/util/pathnode.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Improve performance of pg_strtointNN functions
Next
From: Tom Lane
Date:
Subject: pgsql: Re-pgindent a few files.