pgsql: Remove promote_trigger_file. - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Remove promote_trigger_file.
Date
Msg-id E1oznIt-001DZ5-Dp@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove promote_trigger_file.

Previously, an idle startup (recovery) process would wake up every 5
seconds to have a chance to poll for promote_trigger_file, even if that
GUC was not configured.  That promotion triggering mechanism was
effectively superseded by pg_ctl promote and pg_promote() a long time
ago.  There probably aren't many users left and it's very easy to change
to the modern mechanisms, so we agreed to remove the feature.

This is part of a campaign to reduce wakeups on idle systems.

Author: Simon Riggs <simon.riggs@enterprisedb.com>
Reviewed-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Ian Lawrence Barwick <barwick@gmail.com>
Discussion: https://postgr.es/m/CANbhV-FsjnzVOQGBpQ589%3DnWuL1Ex0Ykn74Nh1hEjp2usZSR5g%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cd4329d9393f84dce34f0bd2dd936adc8ffaa213

Modified Files
--------------
.../sgml/appendix-obsolete-recovery-config.sgml    | 13 ++---
doc/src/sgml/config.sgml                           | 18 -------
doc/src/sgml/high-availability.sgml                | 22 +++------
src/backend/access/transam/xlogrecovery.c          | 57 ++++++----------------
src/backend/utils/misc/guc_tables.c                | 10 ----
src/backend/utils/misc/postgresql.conf.sample      |  1 -
src/include/access/xlogrecovery.h                  |  1 -
7 files changed, 29 insertions(+), 93 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: meson: Fix binary mismatch for MSVC plperl vs gcc built perl lib
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix comment in snapbuild.c