pgsql: Make PostgreSQL::Test::Cluster::config_data more flexible - Mailing list pgsql-committers

From Andrew Dunstan
Subject pgsql: Make PostgreSQL::Test::Cluster::config_data more flexible
Date
Msg-id E1ouDao-0001Dz-25@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make PostgreSQL::Test::Cluster::config_data more flexible

Currently this only allows for one argument, which must be present, and
always returns a single string. With this change the following now all
work:

  $all_config = $node->config_data;
  %config_map = ($node->config_data);
  $incdir = $node->config_data('--include-dir');
  ($incdir, $sharedir) = $node->config_data(
      qw(--include-dir --share-dir));

Backpatch to release 15 where this was introduced.

Discussion: https://postgr.es/m/73eea68e-3b6f-5f63-6024-25ed26b52016@dunslane.net

Reviewed by Tom Lane, Alvaro Herrera, Michael Paquier.

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7a387f513d6c583b1c3fe5e4e0ea2b8cb92c85da

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 43 ++++++++++++++++++++++++++------
1 file changed, 35 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Refactor aclcheck functions
Next
From: Andrew Dunstan
Date:
Subject: pgsql: Use installed postgresql.conf.sample for GUC sanity TAP test