pgsql: pg_dump test: Make concatenated create_sql commands more readabl - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: pg_dump test: Make concatenated create_sql commands more readabl
Date
Msg-id E1opUrc-001bj9-Ja@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_dump test: Make concatenated create_sql commands more readable

When the pg_dump 002_pg_dump.pl test generates the command to load the
schema, it does

    # Add terminating semicolon
    $create_sql{$test_db} .= $tests{$test}->{create_sql} . ";";

In some cases, this creates a duplicate semicolon, but more
importantly, this doesn't add any newline.  So if you look at the
result in either the server log or in
tmp_check/log/regress_log_002_pg_dump, it looks like a complete mess.
This patch makes the output look cleaner for manual inspection: add
semicolon only if necessary, and add two newlines.

Discussion: https://www.postgresql.org/message-id/flat/d6aec95a-8729-43cc-2578-f2a5e46640e0%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6e10631d1e6e350ba3f82b0bd3a29678f9f5badd

Modified Files
--------------
src/bin/pg_dump/t/002_pg_dump.pl | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Add check on initial and boot values when loading GUCs
Next
From: Jeff Davis
Date:
Subject: pgsql: Fix ALTER COLLATION "default" REFRESH VERSION.