pgsql: autoconf: Rely on ar supporting index creation - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: autoconf: Rely on ar supporting index creation
Date
Msg-id E1ogsdg-001LzD-90@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
autoconf: Rely on ar supporting index creation

This way we don't need RANLIB anymore, making it a bit simpler for the meson
build to generate Makefile.global for PGXS compatibility.

FreeBSD, NetBSD, OpenBSD, the only platforms where we didn't use AROPT=crs,
all have supported the 's' option for a long time.

On macOS we ran ranlib after installing a static library. This was added a
long time ago, in 58ad65ec2def. I cannot reproduce an issue in more recent
macOS versions. This is removed now.

Based on discussion with Tom, I left the 'touch' at the end of static
libraries generation, added in 826eff57c4c, in place. While it looks like
current versions of Apple's ar/ranlib don't need it, it was needed not too
long ago.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20221005200710.luvw5evhwf6clig6@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2473cb9ff374dff99437138c144fab6d9f7dfd26

Modified Files
--------------
configure                      | 93 ------------------------------------------
configure.ac                   |  1 -
src/Makefile.global.in         |  2 +-
src/Makefile.shlib             |  7 +---
src/makefiles/Makefile.aix     |  3 --
src/makefiles/Makefile.cygwin  |  2 -
src/makefiles/Makefile.darwin  |  2 -
src/makefiles/Makefile.freebsd |  2 -
src/makefiles/Makefile.linux   |  2 -
src/makefiles/Makefile.netbsd  |  2 -
src/makefiles/Makefile.openbsd |  2 -
src/makefiles/Makefile.solaris |  2 -
src/makefiles/Makefile.win32   |  2 -
13 files changed, 2 insertions(+), 120 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Remove unnecessary uses of Abs()
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Use fabsf() instead of Abs() or fabs() where appropriate