pgsql: Create subscription stats entry at CREATE SUBSCRIPTION time - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Create subscription stats entry at CREATE SUBSCRIPTION time
Date
Msg-id E1ogb93-001ESo-0P@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Create subscription stats entry at CREATE SUBSCRIPTION time

Previously, the subscription stats entry was created when the first
stats, i.e., an error on apply worker or tablesync worker,  were
reported. Therefore, the stats_reset field was not updated by
pg_stat_reset_subscription_stats() if the stats entry was not
populated yet, which was different behavior than other statistics.

This change creates the subscription stats entry and initializes it at
CREATE SUBSCRIPTION time.

Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://postgr.es/m/CAAKRu_Zqd-e5imT_3-ZiQv1cfsWuy16OJTiUaCvqpq4V7GVdSg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e0b0142959066f3a9de1c6867f4ec8d41d104f33

Modified Files
--------------
src/backend/utils/activity/pgstat_subscription.c |  8 ++++--
src/test/regress/expected/subscription.out       | 34 ++++++++++++++++++++++++
src/test/regress/sql/subscription.sql            | 11 ++++++++
3 files changed, 51 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Fix final warnings produced by -Wshadow=compatible-local
Next
From: Tom Lane
Date:
Subject: pgsql: Improve our ability to detect bogus pointers passed to pfree et