pgsql: Adjust PQsslAttributeNames() to match PQsslAttribute(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Adjust PQsslAttributeNames() to match PQsslAttribute().
Date
Msg-id E1oeGya-000IWI-Q5@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Adjust PQsslAttributeNames() to match PQsslAttribute().

Currently, PQsslAttributeNames() returns the same list of attribute
names regardless of its conn parameter.  This patch changes it to
have behavior parallel to what 80a05679d installed for PQsslAttribute:
you get OpenSSL's attributes if conn is NULL or is an SSL-encrypted
connection, or an empty list if conn is a non-encrypted connection.
The point of this is to have sensible connection-dependent behavior
in case we ever support multiple SSL libraries.  The behavior for
NULL can be defined as "the attributes for the default SSL library",
parallel to what PQsslAttribute(NULL, "library") does.

Since this is mostly just future-proofing, no back-patch.

Discussion: https://postgr.es/m/17625-fc47c78b7d71b534@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4e4f7b9fcc9ad0b023b6e698e978882d022b94c4

Modified Files
--------------
doc/src/sgml/libpq.sgml                  | 12 +++++++++++-
src/interfaces/libpq/fe-secure-openssl.c | 15 +++++++++++++--
2 files changed, 24 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Fix tab-completion after commit 790bf615ddba
Next
From: Andres Freund
Date:
Subject: pgsql: mingw: Define PGDLLEXPORT as __declspec (dllexport) as done for